-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31854/
-----------------------------------------------------------

(Updated March 9, 2015, 5:05 p.m.)


Review request for ranger.


Changes
-------

Rework comments addressed.
changes to pom to suppress a warning.


Bugs: RANGER-278
    https://issues.apache.org/jira/browse/RANGER-278


Repository: ranger


Description
-------

- policy validation
- rework comments from https://reviews.apache.org/r/31763/ addressed (Unable to 
apply patch to that review)
- id is ignored for create of service and policy, allow for updating of 
policy/service name


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 
ab8384c 
  pom.xml 7cf894b 
  
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java 
PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java 
08184c7 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java fc2178f 
  
security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java
 PRE-CREATION 
  
security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java
 483e914 

Diff: https://reviews.apache.org/r/31854/diff/


Testing
-------

Madhan,
I was not able to apply this patch to prior review hence, I had to create a new 
review. :(
JUnits were updated to account for review comments about optional id and update 
of name.


Thanks,

Alok Lal

Reply via email to