-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31959/
-----------------------------------------------------------
(Updated March 11, 2015, 6:24 p.m.)
Review request for ranger.
Changes
-------
RANGER-304 Validation does several checks now in case-insensitive manner.
Check for parameter names of a service are left as is because making them
case-insensitive would require corresponding changes in test-service code.
Junits were changed to excercise case-insesitive parts, i.e. they would fail if
code wasn't doing case-insensitive comparison for both happypath and failure
cases.
This change-set is applied as a "rework" of this review since it assumes that
service-def validation code is committed in. Since that is still in review
(and not committed in) it wasn't possible to create a review of just these
changes. Hence, they are submitted here as a diff of service-def validation
changes.
Bugs: RANGER-299
https://issues.apache.org/jira/browse/RANGER-299
Repository: ranger
Description
-------
Validations for service def
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java
941bb21
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java
b6948dc
security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java
4e15753
security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceDefValidator.java
PRE-CREATION
security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java
d3ee6d6
Diff: https://reviews.apache.org/r/31959/diff/
Testing
-------
Additional junits and existing ones.
Thanks,
Alok Lal
