----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31959/#review76209 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31959/#comment123695> Validation classes are placed in "org.apache.ranger.rest" package. Can this be moved to "org.apache.ranger.plugin.model.validation" package, in ranger-plugins-common.jar, where the validation can be used outside of the web-application. security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java <https://reviews.apache.org/r/31959/#comment123691> Please add validation for policyConditions and contextEnhancers. security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java <https://reviews.apache.org/r/31959/#comment123692> Please use case-insensitive comparision - to check for duplicate access-types/incorrect implied access grant. - Madhan Neethiraj On March 12, 2015, 1:24 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31959/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 1:24 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-299 > https://issues.apache.org/jira/browse/RANGER-299 > > > Repository: ranger > > > Description > ------- > > Validations for service def > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java > 941bb21 > > security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java > b6948dc > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java > 4e15753 > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceDefValidator.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java > d3ee6d6 > > Diff: https://reviews.apache.org/r/31959/diff/ > > > Testing > ------- > > Additional junits and existing ones. > > > Thanks, > > Alok Lal > >
