----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32066/#review76478 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 14, 2015, 2:19 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32066/ > ----------------------------------------------------------- > > (Updated March 14, 2015, 2:19 a.m.) > > > Review request for ranger and Abhay Kulkarni. > > > Bugs: RANGER-307 > https://issues.apache.org/jira/browse/RANGER-307 > > > Repository: ranger > > > Description > ------- > > This patch implements first level of optimizations to make policy engine > execute faster. This is achieved by > 1. Sorting the policies in the order which is most likely to find a "ALLOW" > for the requested access to the resource. > 2. Using some short-cuts to discard policies that are definitely going to > allow the requested access to the resource. > 3. Perform resource-name matching as late as possible as it is potentially an > expensive operation. > 4. Use lookup to check if the audit is desired for a requested resource > because of a previous execution of policy engine for the same resource. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/CacheMap.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessData.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > 2eaec16 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 51787ac > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEvaluatorFacade.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 0ac5eed > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluatorTest.java > 9256995 > agents-common/src/test/resources/policyengine/test_policyengine_hdfs.json > 943fe80 > pom.xml 7df033d > src/main/assembly/ranger-src.xml cf6b1da > > Diff: https://reviews.apache.org/r/32066/diff/ > > > Testing > ------- > > Verified that existing policy engine unit tests succeed. > > > Thanks, > > Madhan Neethiraj > >
