----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34029/ -----------------------------------------------------------
Review request for ranger, Gautam Borad, Madhan Neethiraj, and Velmurugan Periasamy. Repository: ranger Description ------- Following changes have been made to policy resource signature: - Signature should get updated on update - Signature should include policy type (include/exclude) in it. - Add version number to signature - Skip signature check for disabled policies - Signature check should not span services. It should be possible to create same policies for different services, e.g. different hdfs clusters - Signature check should exclude disabled policies. Diffs ----- agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java 62fdabc agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 1acf81f agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java ec16eee agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java 2ce08bb agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java 708fbd2 agents-common/src/main/java/org/apache/ranger/plugin/store/file/ServiceFileStore.java 00b7521 agents-common/src/main/java/org/apache/ranger/plugin/store/rest/ServiceRESTStore.java 5c742f9 agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java 46e924f agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java 5828f6f agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java 01c0e6d security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java e6bbc15 security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java eb7c2aa security-admin/src/main/resources/META-INF/jpa_named_queries.xml 737675d Diff: https://reviews.apache.org/r/34029/diff/ Testing ------- - Manual update of polices, existing policies when they are enabled/disabled or belong to different service of same type. Creation of policies with same resource but for different service - Existing junits updated, new junits added. Thanks, Alok Lal
