----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34029/#review83262 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On May 11, 2015, 6:47 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34029/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 6:47 p.m.) > > > Review request for ranger, Gautam Borad, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Repository: ranger > > > Description > ------- > > Following changes have been made to policy resource signature: > - Signature should get updated on update > - Signature should include policy type (include/exclude) in it. > - Add version number to signature > - Skip signature check for disabled policies > - Signature check should not span services. It should be possible to create > same policies for different services, e.g. different hdfs clusters > - Signature check should exclude disabled policies. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > e6bbc15 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java eb7c2aa > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 737675d > > Diff: https://reviews.apache.org/r/34029/diff/ > > > Testing > ------- > > - Manual update of polices, existing policies when they are enabled/disabled > or belong to different service of same type. > Creation of policies with same resource but for different service > - Existing junits updated, new junits added. > > > Thanks, > > Alok Lal > >
