----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34118/#review83469 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java <https://reviews.apache.org/r/34118/#comment134464> Please check if loadFromCache() throws exception in some cases. Then, the next statement may not always be executed. - Abhay Kulkarni On May 12, 2015, 7:48 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34118/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 7:48 p.m.) > > > Review request for ranger, Alok Lal, dilli dorai, Madhan Neethiraj, and > Selvamohan Neethiraj. > > > Repository: ranger > > > Description > ------- > > Ranger-466: PolicyRefresher should timeout when Ranger Admin is non > responsive and should use local cache for policy enforcement if present. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > 36548e4 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > 1d57935 > > Diff: https://reviews.apache.org/r/34118/diff/ > > > Testing > ------- > > Test done > - Simulate timeout by putting delay on rest call > - Verify Policy load from cache when timeout. > - Verify Policy load when Policy manager is down. > - Policy load from cache should be done one once. > - If local is not present no policy enforcement happens. > > > Thanks, > > Ramesh Mani > >
