> On May 12, 2015, 8:38 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java, > > line 192 > > <https://reviews.apache.org/r/34118/diff/1/?file=956726#file956726line192> > > > > Please check if loadFromCache() throws exception in some cases. Then, > > the next statement may not always be executed.
No Exception thrown, but I execute the next statement whether loadFromCache() succeeded or not. That sould take care of this. - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34118/#review83469 ----------------------------------------------------------- On May 13, 2015, 12:23 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34118/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 12:23 a.m.) > > > Review request for ranger, Alok Lal, dilli dorai, Madhan Neethiraj, and > Selvamohan Neethiraj. > > > Repository: ranger > > > Description > ------- > > Ranger-466: PolicyRefresher should timeout when Ranger Admin is non > responsive and should use local cache for policy enforcement if present. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > 36548e4 > > Diff: https://reviews.apache.org/r/34118/diff/ > > > Testing > ------- > > Test done > - Simulate timeout by putting delay on rest call > - Verify Policy load from cache when timeout. > - Verify Policy load when Policy manager is down. > - Policy load from cache should be done one once. > - If local is not present no policy enforcement happens. > > > Thanks, > > Ramesh Mani > >
