-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34180/
-----------------------------------------------------------
(Updated May 15, 2015, 4:21 p.m.)
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Ramesh Mani.
Changes
-------
Review comments addressed.
Bugs: RANGER-265
https://issues.apache.org/jira/browse/RANGER-265
Repository: ranger
Description (updated)
-------
Lookup and validation Calls to serices are done asynchrenously. Default
Timeout value is distributed with the default-site-config with a provision to
specify service-level override.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/service/ResourceLookupContext.java
913f824
security-admin/pom.xml 9783d1f
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
009cbf8
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 8498fbf
security-admin/src/main/java/org/apache/ranger/common/LookupConfigurator.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/common/PropertiesHelper.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/common/RangerFactory.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/common/TimedExecutorConfigurator.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/service/RangerFactory.java
7834262
security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml
571d2a1
security-admin/src/test/java/org/apache/ranger/common/TestLookupConfigurator.java
PRE-CREATION
security-admin/src/test/java/org/apache/ranger/common/TestTimedExecutor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34180/diff/
Testing (updated)
-------
1. Resouce lookup for hive, hdfs and hbase tested. Time taken to schedule and
execute the lookup calls looks fine.
2. New test added to assert the executor behaviors around:
-- successful execution
-- timeout during or waiting for execution
-- rejection due to queue capacity limit
Thanks,
Alok Lal
