----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39122/#review101928 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java (line 270) <https://reviews.apache.org/r/39122/#comment159431> In this case, vxUserPermission.userId will be null. Will this userpermission object be useful? Would this cause failure in persisting in the db? security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java (line 272) <https://reviews.apache.org/r/39122/#comment159434> XXUserPermission.userId now has XXUser.id, instead of XXPortalUser.id. Please review all uses of XXUserPermission.userId to make sure that XXUser.id is used to store/compare. For example in XXModuleDefDao.findAccessibleModulesByUserId(). Also, what is the plan to update existing entries in XXUserPermission table? security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java (line 283) <https://reviews.apache.org/r/39122/#comment159432> What does 'isCreate' flag mean here? It seems the code updates existing object if this flag is set.. - Madhan Neethiraj On Oct. 8, 2015, 1:05 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39122/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 1:05 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan > Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-688 > https://issues.apache.org/jira/browse/RANGER-688 > > > Repository: ranger > > > Description > ------- > > Patch takes care of managing the users permissions even if ids (XUser and > XPortalUser ids) are not in sync > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java > 5f43bc020df6842cc04708113fa46c4b370ac854 > security-admin/src/main/java/org/apache/ranger/common/UserSessionBase.java > 59e55f3e1db02f1fdd2d03dd22183929b1173027 > security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java > d3467f86aefccca9b0387e382628b95e4466eecd > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java > 088759469608ab45e3ad3341ad2bf6558a30f5d9 > security-admin/src/main/java/org/apache/ranger/db/XXUserPermissionDao.java > e10dc14fdcb58265467aa02d0a9b9b2aea1040ad > > security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java > f0aa938dd918124e050ee54a3dcc64e86e3f5236 > > security-admin/src/main/java/org/apache/ranger/service/XUserPermissionService.java > 3ff9c8d0ac070032089bcbc9f5c3c33c401b30b3 > > security-admin/src/main/java/org/apache/ranger/service/XUserPermissionServiceBase.java > 59c082d2760acc8bd296b29497ab763cbb97c407 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml > 0370e9abe60582152f6d71ac8e0ed8312e4f2e7f > > Diff: https://reviews.apache.org/r/39122/diff/ > > > Testing > ------- > > Tested by creating a XPOrtalUser user using curl command and then for a new > user, assigned permissions to check if permissions are not messed up. > > > Thanks, > > Gautam Borad > >
