----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45292/#review125278 -----------------------------------------------------------
ugsync/src/test/resources/ranger-ugsync-site.xml (line 108) <https://reviews.apache.org/r/45292/#comment188063> Could we use conventional name for substitution variable? For example, install scripts use the DOS style %BLAH% to denote a substitutable variable. It reduces changes of accidental breakage in future caused by name conflict. - Alok Lal On March 24, 2016, 8:36 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45292/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 8:36 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Change Apache DS tests to run on a random port > > > Diffs > ----- > > ugsync/src/test/java/org/apache/ranger/usergroupsync/LdapUserGroupTest.java > 68ddfef > ugsync/src/test/resources/ranger-ugsync-site.xml 0b2c991 > > Diff: https://reviews.apache.org/r/45292/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
