> On March 24, 2016, 4:35 p.m., Alok Lal wrote: > > ugsync/src/test/resources/ranger-ugsync-site.xml, line 108 > > <https://reviews.apache.org/r/45292/diff/1/?file=1313906#file1313906line108> > > > > Could we use conventional name for substitution variable? For example, > > install scripts use the DOS style %BLAH% to denote a substitutable > > variable. It reduces changes of accidental breakage in future caused by > > name conflict.
I've reworked the patch to generate a random free port in a maven plugin, and this automatically gets substituted into the ranger-ugsync-site.xml. The testcode just reads the port number from a system property. This is much cleaner than the previous patch IMO. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45292/#review125278 ----------------------------------------------------------- On March 24, 2016, 3:36 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45292/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 3:36 p.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Change Apache DS tests to run on a random port > > > Diffs > ----- > > ugsync/src/test/java/org/apache/ranger/usergroupsync/LdapUserGroupTest.java > 68ddfef > ugsync/src/test/resources/ranger-ugsync-site.xml 0b2c991 > > Diff: https://reviews.apache.org/r/45292/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
