----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46019/#review128335 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 1825) <https://reviews.apache.org/r/46019/#comment191761> If user wants to download policies for 10 services then this logic will goto database 10 times to find policies for each service. Rather this, can't we get all the policies of all given services with one database call ? Just concern about the performance. security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 1872) <https://reviews.apache.org/r/46019/#comment191762> Just a minor correction, arrow pointing in wrong direction: LOG.debug("==> ServiceDBStore.getPoliciesInExcel()") security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java (line 137) <https://reviews.apache.org/r/46019/#comment191763> This will throw NPE at this line if `xuser` is null. Also just to maintain consistensy if we can use camelCase naming convention, it will be good. user_id --> userId security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java (line 138) <https://reviews.apache.org/r/46019/#comment191764> Rather querying for only groupId, querying for XXGroup and iterating over List<XXGroup> will be helpful because anyways at line no. #141 XXGroup object is required so that database call at #141 is avoidable. - Tushar Dudhatra On April 11, 2016, 12:35 p.m., Mehul Parikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46019/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 12:35 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan > Neethiraj. > > > Bugs: RANGER-913 > https://issues.apache.org/jira/browse/RANGER-913 > > > Repository: ranger > > > Description > ------- > > ** PROBLEM STATEMENT ** > Improve current reporting to provide a functionality for user to get access > to a given resource or set of resources across Hadoop (resource could include > tags as well) > Also include ability to download the report to a Excel. > > ** PROPOSED SOLUTION ** > > 1) Added Resources and permissions in searched list of policies table. > 2) Added feature of download Excel in reports. > 3) Allowing to search policies for selected component. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 61e8b09 > pom.xml c21299d > security-admin/pom.xml b9590bf > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 9d2e4c6 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 8f01bfc > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java > 4929cf6 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > 47177f4 > security-admin/src/main/webapp/styles/xa.css 331cda1 > security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html > 1352882 > > Diff: https://reviews.apache.org/r/46019/diff/ > > > Testing > ------- > > Verified : Search result of policies based on below given criterias. > > 1) Search by User > 2) Search By Group > 3) Search by multiple service types > 4) Verified combinations of these and also checked download Excel feature > based on search. > > > Thanks, > > Mehul Parikh > >
