> On April 12, 2016, 5:24 a.m., Tushar Dudhatra wrote: > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java, > > line 1830 > > <https://reviews.apache.org/r/46019/diff/1/?file=1339197#file1339197line1830> > > > > If user wants to download policies for 10 services then this logic will > > goto database 10 times to find policies for each service. Rather this, > > can't we get all the policies of all given services with one database call > > ? > > Just concern about the performance.
Implementation will not make DB calls for each service, instead it will make DB call for each serviceType. So if we have 10 services in HDFS and 10 services in HIVE, still it will make only 2 DB calls, one for HDFS and one for HIVE. For readability, I have replaced the variable name from services to serviceTypeNames. - Mehul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46019/#review128335 ----------------------------------------------------------- On April 14, 2016, 8:51 a.m., Mehul Parikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46019/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 8:51 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan > Neethiraj. > > > Bugs: RANGER-913 > https://issues.apache.org/jira/browse/RANGER-913 > > > Repository: ranger > > > Description > ------- > > ** PROBLEM STATEMENT ** > Improve current reporting to provide a functionality for user to get access > to a given resource or set of resources across Hadoop (resource could include > tags as well) > Also include ability to download the report to a Excel. > > ** PROPOSED SOLUTION ** > > 1) Added Resources and permissions in searched list of policies table. > 2) Added feature of download Excel in reports. > 3) Allowing to search policies for selected component. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 61e8b09 > pom.xml 03815c1 > security-admin/pom.xml 5e03564 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 9d2e4c6 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 8f01bfc > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java > 4929cf6 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > 47177f4 > security-admin/src/main/webapp/styles/xa.css 331cda1 > security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html > 1352882 > > Diff: https://reviews.apache.org/r/46019/diff/ > > > Testing > ------- > > Verified : Search result of policies based on below given criterias. > > 1) Search by User > 2) Search By Group > 3) Search by multiple service types > 4) Verified combinations of these and also checked download Excel feature > based on search. > > > Thanks, > > Mehul Parikh > >
