----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48522/#review137155 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 2199) <https://reviews.apache.org/r/48522/#comment202311> Value returned from ServiceDBStore.getServicePoliciesIfUpdated() is cached in policy engine. Removing disabled policies from this cache may not be a good idea. Consider moving filterServicePolicies() to ServiceREST - so that the disabled policies will be removed only when returning to plugin's request to download policies. - Madhan Neethiraj On June 9, 2016, 11:35 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48522/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 11:35 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1021 > https://issues.apache.org/jira/browse/RANGER-1021 > > > Repository: ranger > > > Description > ------- > > Currently, all ranger policies for the service are downloaded to the plugin > that makes the policy-download request. Only those policies that are in > 'Enabled' state need to be downloaded in order to save network band-width and > spurious processing overhead on the plugin side. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > bf03e30 > > Diff: https://reviews.apache.org/r/48522/diff/ > > > Testing > ------- > > Created Ranger policy with state 'Enabled'. Checked the policy cache on the > component to ensure that it was in its policy-cache. Then edited the policy > to set its state to 'Disabled'. After policies were downloaded to the > component, checked the policy-cache again to ensure that disabled policy was > not in it. Repeated these steps for a tag-policy in a tag-service associated > with the component's service. > > > Thanks, > > Abhay Kulkarni > >
