----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48522/#review137232 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java (line 1806) <https://reviews.apache.org/r/48522/#comment202394> apply filterServicePolicies() here as well..in addition to getSecureServicePoliciesIfUpdated() security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java (line 2345) <https://reviews.apache.org/r/48522/#comment202395> if servicePolicies doesn't contain any disabled policy, there is n need to create a copy - simply return servicePolicies. If most services may not have a disabled policy, this optimization can be be helpful. Please review. - Madhan Neethiraj On June 12, 2016, 8:01 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48522/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 8:01 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1021 > https://issues.apache.org/jira/browse/RANGER-1021 > > > Repository: ranger > > > Description > ------- > > Currently, all ranger policies for the service are downloaded to the plugin > that makes the policy-download request. Only those policies that are in > 'Enabled' state need to be downloaded in order to save network band-width and > spurious processing overhead on the plugin side. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 646554e > > Diff: https://reviews.apache.org/r/48522/diff/ > > > Testing > ------- > > Created Ranger policy with state 'Enabled'. Checked the policy cache on the > component to ensure that it was in its policy-cache. Then edited the policy > to set its state to 'Disabled'. After policies were downloaded to the > component, checked the policy-cache again to ensure that disabled policy was > not in it. Repeated these steps for a tag-policy in a tag-service associated > with the component's service. > > > Thanks, > > Abhay Kulkarni > >
