-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50511/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1124
https://issues.apache.org/jira/browse/RANGER-1124
Repository: ranger
Description
-------
Code changes to guard against potential NPEs and other potential run-time
issues; good coding practices.
Diffs
-----
credentialbuilder/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java
ecede34
credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java
d8ffe2c
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
a74f8d1
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java
ef80f43
jisql/src/main/java/org/apache/util/sql/Jisql.java 36c4340
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java b2eda30
kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 606706b
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java abfab25
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java d70ec4e
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java
3674e7a
kms/src/main/java/org/apache/ranger/entity/XXDBBase.java a0d0120
plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSClient.java
5337ee3
plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSResourceMgr.java
e61d0bc
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 5ecae8d
security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java 693e959
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java e0a9840
security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java
3ba33d4
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
7947d4b
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 0059884
security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java 2e9d6d5
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java a508926
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 86f9d96
security-admin/src/main/java/org/apache/ranger/common/ErrorMessageUtil.java
582580c
security-admin/src/main/java/org/apache/ranger/common/RangerProperties.java
72fde46
security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
a68b215
security-admin/src/main/java/org/apache/ranger/common/RangerServiceTagsCache.java
66c1562
security-admin/src/main/java/org/apache/ranger/common/SearchField.java
1891edb
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java
c1baae8
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 13607d3
security-admin/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java
429be27
security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java e25540b
security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java
5291045
security-admin/src/main/java/org/apache/ranger/patch/PatchForServiceVersionInfo_J10004.java
380cca0
security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java
54148f1
security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java
3a3bed2
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 3d649df
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 1f465d5
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 1185e45
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
e84a1aa
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 3dfb250
security-admin/src/main/java/org/apache/ranger/rest/XKeyREST.java b07bf9c
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 226d3c7
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
3fa3436
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
6496698
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java
d431bc1
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java
7314782
security-admin/src/main/java/org/apache/ranger/security/web/filter/SSOAuthentication.java
6fcadb7
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java
6c7e1f0
security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
65ad5ad
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
4b792de
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
2649ff3
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java
839bf59
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java
f28ccca
security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 1b5793f
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java e912cfb
security-admin/src/main/java/org/apache/ranger/view/VXAuditRecordList.java
42ff4d1
security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java
637e43f
Diff: https://reviews.apache.org/r/50511/diff/
Testing
-------
Built clean and ran unit tests
installed ranger and ranger-kms.
Tested create/update/delete operation on service, policy, users and groups.
Thanks,
Pradeep Agrawal
