-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50511/
-----------------------------------------------------------
(Updated July 29, 2016, 2:15 a.m.)
Review request for ranger.
Changes
-------
Addressed review comments.
Bugs: RANGER-1124
https://issues.apache.org/jira/browse/RANGER-1124
Repository: ranger
Description
-------
Code changes to guard against potential NPEs and other potential run-time
issues; good coding practices.
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java abfab25
plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSResourceMgr.java
e61d0bc
security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java 693e959
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java e0a9840
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
03fe840
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 0059884
security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java 2e9d6d5
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java a508926
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 86f9d96
security-admin/src/main/java/org/apache/ranger/common/SearchField.java
1891edb
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java
c1baae8
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 13607d3
security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java e25540b
security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java
5291045
security-admin/src/main/java/org/apache/ranger/entity/XXContextEnricherDef.java
e035e58
security-admin/src/main/java/org/apache/ranger/entity/XXPolicyBase.java
8564d43
security-admin/src/main/java/org/apache/ranger/entity/XXPolicyConditionDef.java
d738841
security-admin/src/main/java/org/apache/ranger/entity/XXPolicyItemUserPerm.java
874ca20
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 3d649df
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 1185e45
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 3dfb250
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
3fa3436
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
6496698
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java
d431bc1
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java
7314782
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
4b792de
security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 1b5793f
Diff: https://reviews.apache.org/r/50511/diff/
Testing
-------
Built clean and ran unit tests
installed ranger and ranger-kms.
Tested create/update/delete operation on service, policy, users and groups.
Thanks,
Pradeep Agrawal
