----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53020/#review153320 -----------------------------------------------------------
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java (line 1) <https://reviews.apache.org/r/53020/#comment222610> Hi Colm, Thanks for the patch. Could you please address the below? 1] Explore creating the jks files on the fly? This can avoid including binary files in the code base. 2] It can also avoid the error applying the patch. I get the below error. ```$ git apply --verbose --check -v < ~/Downloads/patches/ranger/0001-RANGER-1188-Create-tests-for-the-Kafka-plugin.patch error: unrecognized binary patch at line 978 Checking patch plugin-kafka/pom.xml... ```.... 3] Any estimate on how long these tests will take to complete? It is better not to significantly increase the build time. - Velmurugan Periasamy On Oct. 19, 2016, 2:42 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53020/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 2:42 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1188 > https://issues.apache.org/jira/browse/RANGER-1188 > > > Repository: ranger > > > Description > ------- > > Create tests for the Kafka plugin > > > Diffs > ----- > > plugin-kafka/pom.xml 4e2334d > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java > PRE-CREATION > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/RangerAdminClientImpl.java > PRE-CREATION > plugin-kafka/src/test/resources/brokerstore.jks PRE-CREATION > plugin-kafka/src/test/resources/clientstore.jks PRE-CREATION > plugin-kafka/src/test/resources/kafka-policies.json PRE-CREATION > plugin-kafka/src/test/resources/ranger-kafka-security.xml PRE-CREATION > plugin-kafka/src/test/resources/servicestore.jks PRE-CREATION > plugin-kafka/src/test/resources/truststore.jks PRE-CREATION > > Diff: https://reviews.apache.org/r/53020/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
