> On Oct. 19, 2016, 11:20 p.m., Velmurugan Periasamy wrote: > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java, > > line 1 > > <https://reviews.apache.org/r/53020/diff/1/?file=1541467#file1541467line1> > > > > Hi Colm, > > > > Thanks for the patch. Could you please address the below? > > > > 1] Explore creating the jks files on the fly? This can avoid including > > binary files in the code base. > > > > 2] It can also avoid the error applying the patch. I get the below > > error. > > ```$ git apply --verbose --check -v < > > ~/Downloads/patches/ranger/0001-RANGER-1188-Create-tests-for-the-Kafka-plugin.patch > > error: unrecognized binary patch at line 978 > > Checking patch plugin-kafka/pom.xml... > > ```.... > > > > 3] Any estimate on how long these tests will take to complete? It is > > better not to significantly increase the build time.
Hi Vel, Yes, I updated the patch to use BouncyCastle to create the keys on the fly (you may need to download the patch on the JIRA instead of here). The entire build of the plugin-kafka module including running the tests takes 13 seconds on my machine. Colm. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53020/#review153320 ----------------------------------------------------------- On Oct. 24, 2016, 3:20 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53020/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 3:20 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1188 > https://issues.apache.org/jira/browse/RANGER-1188 > > > Repository: ranger > > > Description > ------- > > Create tests for the Kafka plugin > > > Diffs > ----- > > plugin-kafka/pom.xml 4e2334d > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java > PRE-CREATION > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/RangerAdminClientImpl.java > PRE-CREATION > plugin-kafka/src/test/resources/kafka-policies.json PRE-CREATION > plugin-kafka/src/test/resources/ranger-kafka-security.xml PRE-CREATION > pom.xml 6e39ace > > Diff: https://reviews.apache.org/r/53020/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
