----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54728/#review159222 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java (line 312) <https://reviews.apache.org/r/54728/#comment230163> Instead of dealing with null entries here, consider removing them in RangerPolicyRepository.scrubPolicy(). Also, it will be good to update Ranger Admin to ignore null values while building policy object from the DB contents. This will ensure that null is not returned in REST APIs. - Madhan Neethiraj On Dec. 14, 2016, 1:54 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54728/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2016, 1:54 a.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-1255 > https://issues.apache.org/jira/browse/RANGER-1255 > > > Repository: ranger > > > Description > ------- > > If there are null values in downloaded policies JSON (possibly in > policy-resource-specs, users and groups), then policy-engine initialization > fails. policy-engine should be resilient in the face of such invalid values, > by ignoring them and reporting such values prominently. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java > b8cb864 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 326d650 > > Diff: https://reviews.apache.org/r/54728/diff/ > > > Testing > ------- > > Tested on local VM with policies JSON file with null group names to ensure > policy-engine was initialized without offending (null) groups. All unit tests > passed. > > > Thanks, > > Abhay Kulkarni > >
