----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54728/#review159392 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Dec. 15, 2016, 11:56 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54728/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 11:56 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1255 > https://issues.apache.org/jira/browse/RANGER-1255 > > > Repository: ranger > > > Description > ------- > > If there are null values in downloaded policies JSON (possibly in > policy-resource-specs, users and groups), then policy-engine initialization > fails. policy-engine should be resilient in the face of such invalid values, > by ignoring them and reporting such values prominently. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > b08d4c5 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 326d650 > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java > 5258a74 > > Diff: https://reviews.apache.org/r/54728/diff/ > > > Testing > ------- > > Tested on local VM with policies JSON file with null group names to ensure > policy-engine was initialized without offending (null) groups. All unit tests > passed. > > > Thanks, > > Abhay Kulkarni > >
