----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55483/#review161757 -----------------------------------------------------------
Maybe you could just catch "Exception" here instead of catching all of the other Exception subclasses first? I would also change the String to "JDBC Authentication failure". - Colm O hEigeartaigh On Jan. 13, 2017, 9:13 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55483/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 9:13 a.m.) > > > Review request for ranger, Don Bosco Durai, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1306 > https://issues.apache.org/jira/browse/RANGER-1306 > > > Repository: ranger > > > Description > ------- > > Exception logs were not logged in authenticate function for > RangerAuthenticationProvider.java > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > fd81ad0 > > Diff: https://reviews.apache.org/r/55483/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
