> On 一月 16, 2017, 5:09 p.m., Colm O hEigeartaigh wrote: > > Maybe you could just catch "Exception" here instead of catching all of the > > other Exception subclasses first? I would also change the String to "JDBC > > Authentication failure".
Ok. I agree with your opinion. Now I only log when the exception occurs. I think that the getJDBCAuthentication function shouldn't throw too many exception. The program don't have to catch too many exception when calling getJDBCAuthentication also. The related code will be refactored if I modify the exception logic. Different people have different opinions for refactoring the exception logic code, Perhaps you can modified it. Thanks. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55483/#review161757 ----------------------------------------------------------- On 一月 13, 2017, 9:13 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55483/ > ----------------------------------------------------------- > > (Updated 一月 13, 2017, 9:13 a.m.) > > > Review request for ranger, Don Bosco Durai, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1306 > https://issues.apache.org/jira/browse/RANGER-1306 > > > Repository: ranger > > > Description > ------- > > Exception logs were not logged in authenticate function for > RangerAuthenticationProvider.java > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > fd81ad0 > > Diff: https://reviews.apache.org/r/55483/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
