that sounds good :) I guess right now UT flakiness is the area that needs attention. Trying to be useful in that area.
-Rui On Sun, Aug 9, 2020 at 4:09 AM Tsz Wo Sze <[email protected]> wrote: > +1. Thanks for working on this. > > In general, let's put our energy on the code but do not spend much time on > the imports/whitespaces. :) > > Tsz-Wo > > On Sat, Aug 8, 2020 at 8:58 PM runzhiwang <[email protected]> > wrote: > > > +1 > > > > > > ------------------ 原始邮件 ------------------ > > 发件人: > > "dev" > > < > > [email protected]>; > > 发送时间: 2020年8月9日(星期天) 中午11:47 > > 收件人: "dev"<[email protected]>; > > > > 主题: [DISCUSS] Enable AvoidStarImport in Checkstyle > > > > > > > > Hi community, > > > > Have you ever discussed why "AvoidStarImport" is not enabled? I noticed > > that there are some "import *" existing in the codebase and > > "AvoidStarImport" is not enabled in the checkstyle config. So I opened > [1] > > to both enable it in config and fix "import *". > > > > > > > > [1]: https://github.com/apache/incubator-ratis/pull/173 > > > > -Rui >
