Re: [DISCUSS] Enable AvoidStarImport in Checkstyle

[Rui Wang]

Indeed I am checking "address in use" frequently. Have you ever reproduced
it on your local machine (I failed to do so)



-Rui

On Sun, Aug 9, 2020 at 4:57 PM runzhiwang <wangjie_challe...@qq.com> wrote:

> Hi,
>
>
> If you are interested in flaky UT. You can pay attenation to RATIS-916 and
> RATIS-1017, they all caused by  java.net.BindException: Address already in
> use.
> This is the top one reason cause ut flaky.
>
>
> Thanks,
> runzhiwang
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:
>                                                   "dev"
>                                                                 <
> amaliu...@apache.org&gt;;
> 发送时间:&nbsp;2020年8月10日(星期一) 凌晨2:12
> 收件人:&nbsp;"dev"<dev@ratis.apache.org&gt;;
>
> 主题:&nbsp;Re: [DISCUSS] Enable AvoidStarImport in Checkstyle
>
>
>
> that sounds good :)
>
> I guess right now UT flakiness is the area that needs attention. Trying to
> be useful in that area.
>
>
> -Rui
>
> On Sun, Aug 9, 2020 at 4:09 AM Tsz Wo Sze <szets...@gmail.com&gt; wrote:
>
> &gt; +1. Thanks for working on this.
> &gt;
> &gt; In general, let's put our energy on the code but do not spend much
> time on
> &gt; the imports/whitespaces.&nbsp; :)
> &gt;
> &gt; Tsz-Wo
> &gt;
> &gt; On Sat, Aug 8, 2020 at 8:58 PM runzhiwang <wangjie_challe...@qq.com
> &gt;
> &gt; wrote:
> &gt;
> &gt; &gt; +1&amp;nbsp;
> &gt; &gt;
> &gt; &gt;
> &gt; &gt; ------------------&amp;nbsp;原始邮件&amp;nbsp;------------------
> &gt; &gt; 发件人:
> &gt;
> &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
> "dev"
> &gt;
> &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
> <
> &gt; &gt; amaliu...@apache.org&amp;gt;;
> &gt; &gt; 发送时间:&amp;nbsp;2020年8月9日(星期天) 中午11:47
> &gt; &gt; 收件人:&amp;nbsp;"dev"<dev@ratis.apache.org&amp;gt;;
> &gt; &gt;
> &gt; &gt; 主题:&amp;nbsp;[DISCUSS] Enable AvoidStarImport in Checkstyle
> &gt; &gt;
> &gt; &gt;
> &gt; &gt;
> &gt; &gt; Hi community,
> &gt; &gt;
> &gt; &gt; Have you ever discussed why "AvoidStarImport" is not enabled? I
> noticed
> &gt; &gt; that there are some "import *" existing in the codebase and
> &gt; &gt; "AvoidStarImport" is not enabled in the checkstyle config. So I
> opened
> &gt; [1]
> &gt; &gt; to both enable it in config and fix "import *".
> &gt; &gt;
> &gt; &gt;
> &gt; &gt;
> &gt; &gt; [1]: https://github.com/apache/incubator-ratis/pull/173
> &gt <https://github.com/apache/incubator-ratis/pull/173&gt>; &gt;
> &gt; &gt; -Rui
> &gt;