amaliujia commented on a change in pull request #210:
URL: https://github.com/apache/incubator-ratis/pull/210#discussion_r496144056
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/client/DataStreamReplyDecoder.java
##########
@@ -29,25 +29,22 @@
@Override
protected void decode(ChannelHandlerContext channelHandlerContext,
- ByteBuf byteBuf, List<Object> list) throws Exception {
+ ByteBuf byteBuf, List<Object> list) {
if(byteBuf.readableBytes() >= 24){
Review comment:
Out of curiosity: why this magical number `24`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
