runzhiwang commented on a change in pull request #210:
URL: https://github.com/apache/incubator-ratis/pull/210#discussion_r496309736
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamRequestDecoder.java
##########
@@ -32,28 +31,21 @@ public DataStreamRequestDecoder() {
}
@Override
- protected void decode(ChannelHandlerContext channelHandlerContext,
- ByteBuf byteBuf,
- List<Object> list) throws Exception {
+ protected void decode(ChannelHandlerContext channelHandlerContext, ByteBuf
byteBuf, List<Object> list) {
if(byteBuf.readableBytes() >= 24){
long streamId = byteBuf.readLong();
long dataOffset = byteBuf.readLong();
long dataLength = byteBuf.readLong();
if(byteBuf.readableBytes() >= dataLength){
ByteBuf bf = byteBuf.slice(byteBuf.readerIndex(), (int)dataLength);
bf.retain();
- DataStreamRequestServer req = new DataStreamRequestServer(streamId,
- dataOffset,
- bf);
+ final DataStreamRequestByteBuf req = new
DataStreamRequestByteBuf(streamId, dataOffset, bf);
byteBuf.readerIndex(byteBuf.readerIndex() + (int)dataLength);
byteBuf.markReaderIndex();
list.add(req);
} else {
byteBuf.resetReaderIndex();
Review comment:
if `byteBuf.readableBytes() >= dataLength` is false, do we need to print
err log ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
