szetszwo commented on a change in pull request #210:
URL: https://github.com/apache/incubator-ratis/pull/210#discussion_r496314004
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamRequestDecoder.java
##########
@@ -32,28 +31,21 @@ public DataStreamRequestDecoder() {
}
@Override
- protected void decode(ChannelHandlerContext channelHandlerContext,
- ByteBuf byteBuf,
- List<Object> list) throws Exception {
+ protected void decode(ChannelHandlerContext channelHandlerContext, ByteBuf
byteBuf, List<Object> list) {
if(byteBuf.readableBytes() >= 24){
long streamId = byteBuf.readLong();
long dataOffset = byteBuf.readLong();
long dataLength = byteBuf.readLong();
if(byteBuf.readableBytes() >= dataLength){
ByteBuf bf = byteBuf.slice(byteBuf.readerIndex(), (int)dataLength);
bf.retain();
- DataStreamRequestServer req = new DataStreamRequestServer(streamId,
- dataOffset,
- bf);
+ final DataStreamRequestByteBuf req = new
DataStreamRequestByteBuf(streamId, dataOffset, bf);
byteBuf.readerIndex(byteBuf.readerIndex() + (int)dataLength);
byteBuf.markReaderIndex();
list.add(req);
} else {
byteBuf.resetReaderIndex();
- return;
}
- } else{
Review comment:
This may be a good suggestion but is not related to this issue. This is
a refactoring but not try to change anything to the code.
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamRequestDecoder.java
##########
@@ -32,28 +31,21 @@ public DataStreamRequestDecoder() {
}
@Override
- protected void decode(ChannelHandlerContext channelHandlerContext,
- ByteBuf byteBuf,
- List<Object> list) throws Exception {
+ protected void decode(ChannelHandlerContext channelHandlerContext, ByteBuf
byteBuf, List<Object> list) {
if(byteBuf.readableBytes() >= 24){
long streamId = byteBuf.readLong();
long dataOffset = byteBuf.readLong();
long dataLength = byteBuf.readLong();
if(byteBuf.readableBytes() >= dataLength){
ByteBuf bf = byteBuf.slice(byteBuf.readerIndex(), (int)dataLength);
bf.retain();
- DataStreamRequestServer req = new DataStreamRequestServer(streamId,
- dataOffset,
- bf);
+ final DataStreamRequestByteBuf req = new
DataStreamRequestByteBuf(streamId, dataOffset, bf);
byteBuf.readerIndex(byteBuf.readerIndex() + (int)dataLength);
byteBuf.markReaderIndex();
list.add(req);
} else {
byteBuf.resetReaderIndex();
Review comment:
This may be a good suggestion but is not related to this issue. This is
a refactoring but not try to change anything to the code.
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/client/DataStreamReplyDecoder.java
##########
@@ -29,25 +29,22 @@
@Override
protected void decode(ChannelHandlerContext channelHandlerContext,
- ByteBuf byteBuf, List<Object> list) throws Exception {
+ ByteBuf byteBuf, List<Object> list) {
if(byteBuf.readableBytes() >= 24){
long streamId = byteBuf.readLong();
long dataOffset = byteBuf.readLong();
long dataLength = byteBuf.readLong();
if(byteBuf.readableBytes() >= dataLength){
- DataStreamReplyImpl reply = new DataStreamReplyImpl(streamId,
+ DataStreamReplyByteBuffer reply = new
DataStreamReplyByteBuffer(streamId,
dataOffset,
byteBuf.slice(byteBuf.readerIndex(), (int)
dataLength).nioBuffer());
byteBuf.readerIndex(byteBuf.readerIndex() + (int)dataLength);
byteBuf.markReaderIndex();
list.add(reply);
} else {
byteBuf.resetReaderIndex();
- return;
}
- } else{
Review comment:
This may be a good suggestion but is not related to this issue. This is
a refactoring but not try to change anything to the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
