amaliujia commented on a change in pull request #228:
URL: https://github.com/apache/incubator-ratis/pull/228#discussion_r509012392
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -212,7 +211,7 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg) throws IOExceptio
JavaUtils.allOf(remoteWrites).thenCombine(localWrite, (v,
bytesWritten) -> {
buf.release();
- sendReply(request, ctx);
+ sendReply(request, bytesWritten, ctx);
Review comment:
It might be useful to check whether `bytesWritten` of local write is
equal to `bytesWritten` from replies from remote writes to peers as a correct
check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
