szetszwo commented on a change in pull request #228:
URL: https://github.com/apache/incubator-ratis/pull/228#discussion_r509346878
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -212,7 +211,7 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg) throws IOExceptio
JavaUtils.allOf(remoteWrites).thenCombine(localWrite, (v,
bytesWritten) -> {
buf.release();
- sendReply(request, ctx);
+ sendReply(request, bytesWritten, ctx);
Review comment:
That is a good idea. When bytesWritten is different, it should retry to
send the remaining data. Let's work on it separately since it needs some works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
