szetszwo commented on a change in pull request #234:
URL: https://github.com/apache/incubator-ratis/pull/234#discussion_r513141802
##########
File path: ratis-common/src/main/java/org/apache/ratis/RaftConfigKeys.java
##########
@@ -61,6 +63,16 @@ static SupportedDataStreamType type(RaftProperties
properties, Consumer<String>
static void setType(RaftProperties properties, SupportedDataStreamType
type) {
set(properties::set, TYPE_KEY, type.name());
}
+
+ String ENABLED_KEY = PREFIX + ".enabled";
Review comment:
Instead of add a new configuration, we may add a new type
SupportedDataStreamType.DISABLED. Then, we do not have to complicate the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
