szetszwo commented on a change in pull request #234: URL: https://github.com/apache/incubator-ratis/pull/234#discussion_r513851483
########## File path: ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamDisabled.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ratis.datastream; + +import org.apache.ratis.RaftConfigKeys; +import org.apache.ratis.conf.RaftProperties; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +public class TestDataStreamDisabled extends TestDataStreamBase { + @Rule + public final ExpectedException exception = ExpectedException.none(); + + @Before + public void setup() { + properties = new RaftProperties(); + RaftConfigKeys.DataStream.setType(properties, SupportedDataStreamType.DISABLED); + } + + @Test + public void testDataStreamSingleServer() throws Exception { + exception.expect(UnsupportedOperationException.class); + runTestDataStream(1, 1_000_000, 100); + runTestDataStream(1,1_000, 10_000); + } Review comment: It is not clear when we get UnsupportedOperationException. In the test, we should make sure that server and client can start and work normally. When the client uses the StreamApi, it will get UnsupportedOperationException. ########## File path: ratis-server/src/main/java/org/apache/ratis/server/impl/DisabledDataStreamFactory.java ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ratis.server.impl; + +import org.apache.ratis.client.DataStreamClientFactory; +import org.apache.ratis.client.DataStreamClientRpc; +import org.apache.ratis.conf.Parameters; +import org.apache.ratis.conf.RaftProperties; +import org.apache.ratis.datastream.SupportedDataStreamType; +import org.apache.ratis.protocol.RaftPeer; +import org.apache.ratis.server.DataStreamServerFactory; +import org.apache.ratis.server.DataStreamServerRpc; +import org.apache.ratis.server.RaftServer; +import org.apache.ratis.statemachine.StateMachine; + +import java.io.IOException; +import java.util.Collection; + +/** A stream factory that does nothing when data stream is disabled. */ +public class DisabledDataStreamFactory implements DataStreamServerFactory, DataStreamClientFactory { + public DisabledDataStreamFactory(Parameters parameters){} + + @Override + public DataStreamClientRpc newDataStreamClientRpc(RaftPeer server, RaftProperties properties) { Review comment: These few lines and some other lines below still have 4-space indentation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
