runzhiwang commented on a change in pull request #238:
URL: https://github.com/apache/incubator-ratis/pull/238#discussion_r514185916
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/DataStreamServerImpl.java
##########
@@ -41,15 +41,15 @@ public DataStreamServerImpl(RaftPeer server, StateMachine
stateMachine,
RaftProperties properties, Parameters parameters){
final SupportedDataStreamType type =
RaftConfigKeys.DataStream.type(properties, LOG::info);
- this.serverRpc = DataStreamServerFactory.cast(type.newFactory(parameters))
+ this.serverRpc =
DataStreamServerFactory.cast(type.newServerFactory(parameters))
.newDataStreamServerRpc(server, stateMachine, properties);
}
public DataStreamServerImpl(RaftServer server, StateMachine stateMachine,
RaftProperties properties, Parameters parameters){
final SupportedDataStreamType type =
RaftConfigKeys.DataStream.type(properties, LOG::info);
- this.serverRpc = DataStreamServerFactory.cast(type.newFactory(parameters))
+ this.serverRpc =
DataStreamServerFactory.cast(type.newClientFactory(parameters))
Review comment:
newClientFactory -> newServerFactory ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
