szetszwo commented on a change in pull request #238:
URL: https://github.com/apache/incubator-ratis/pull/238#discussion_r514213541
##########
File path:
ratis-common/src/main/java/org/apache/ratis/datastream/SupportedDataStreamType.java
##########
@@ -20,30 +20,40 @@
import org.apache.ratis.conf.Parameters;
import org.apache.ratis.util.ReflectionUtils;
-public enum SupportedDataStreamType implements DataStreamFactory {
- DISABLED("org.apache.ratis.server.impl.DisabledDataStreamFactory"),
+public enum SupportedDataStreamType implements DataStreamType {
+ DISABLED("org.apache.ratis.client.DisabledDataStreamClientFactory",
+ "org.apache.ratis.server.DisabledDataStreamServerFactory"),
NETTY("org.apache.ratis.netty.NettyDataStreamFactory");
Review comment:
Netty is in ratis-netty which depends on ratis-server and ratis-client.
So splitting it won't be useful at the moment. It will be useful if we split
ratis-netty into ratis-netty-client and ratis-netty-server later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
