szetszwo commented on a change in pull request #349:
URL: https://github.com/apache/incubator-ratis/pull/349#discussion_r540611049
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java
##########
@@ -236,8 +236,10 @@ void initGroups(RaftGroup group) {
addGroup(RaftGroup.valueOf(groupId));
}
} catch (Exception e) {
- LOG.warn(getId() + ": Failed to initialize the group directory
"
- + sub.getAbsolutePath() + ". Ignoring it", e);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(getId() + ": Failed to initialize the group
directory "
+ + sub.getAbsolutePath() + ". Ignoring it", e);
+ }
Review comment:
How about printing an info message but not the stack trace?
```
LOG.info("{}: The directory {} is not a group directory;
ignoring it. {}",
getId(), sub.getAbsolutePath(), e);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
