bharatviswa504 commented on a change in pull request #349:
URL: https://github.com/apache/incubator-ratis/pull/349#discussion_r540628972
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java
##########
@@ -236,8 +236,10 @@ void initGroups(RaftGroup group) {
addGroup(RaftGroup.valueOf(groupId));
}
} catch (Exception e) {
- LOG.warn(getId() + ": Failed to initialize the group directory
"
- + sub.getAbsolutePath() + ". Ignoring it", e);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(getId() + ": Failed to initialize the group
directory "
+ + sub.getAbsolutePath() + ". Ignoring it", e);
+ }
Review comment:
Updated as suggested, and left the existing warning message to handle
any failure during addGroup.
And move the suggested message to before try/catch block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
