runzhiwang commented on a change in pull request #383:
URL: https://github.com/apache/incubator-ratis/pull/383#discussion_r551927347
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -104,6 +104,20 @@ public RaftPeerRole getCurrentRole() {
return getRole().getCurrentRole();
}
+ @Override
+ public boolean isLeader() {
Review comment:
@szetszwo Oh, sorry. By "user", I mean OM or SCM in Ozone, because in OM
HA or SCM HA, they need to check isLeader to decide whether do something, for
example only leader SCM send command to datanode, so SCM need to know whether
it's leader. Then the problem becomes SCM call which method: isLeader() or
isLeaderReady(). From the name of method, maybe SCM is likely to use isLeader().
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -104,6 +104,20 @@ public RaftPeerRole getCurrentRole() {
return getRole().getCurrentRole();
}
+ @Override
+ public boolean isLeader() {
Review comment:
@szetszwo Oh, sorry. By "user", I mean OM or SCM in Ozone, because in OM
HA or SCM HA, they need to check isLeader to decide whether do something, for
example only leader SCM can send command to datanode, so SCM need to know
whether it's leader. Then the problem becomes SCM call which method: isLeader()
or isLeaderReady(). From the name of method, maybe SCM is likely to use
isLeader().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
