runzhiwang commented on a change in pull request #383:
URL: https://github.com/apache/incubator-ratis/pull/383#discussion_r552335190
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -104,6 +104,20 @@ public RaftPeerRole getCurrentRole() {
return getRole().getCurrentRole();
}
+ @Override
+ public boolean isLeader() {
Review comment:
> To maintain the lease, the follower should withhold its vote if its
has replied the AppendEntriesRequest, even it meets a RequestVoteRequest with
higher term and newer raft log. Seems the RequestVote logic is not touched in
this PR ?
@GlenGeng This will be done in Pre-vote PR:
https://github.com/apache/incubator-ratis/pull/161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
