amaliujia commented on a change in pull request #401:
URL: https://github.com/apache/incubator-ratis/pull/401#discussion_r562261994
##########
File path: ratis-common/src/main/java/org/apache/ratis/protocol/RaftPeer.java
##########
@@ -132,6 +170,8 @@ private RaftPeerProto buildRaftPeerProto() {
.setId(getId().toByteString());
Optional.ofNullable(getAddress()).ifPresent(builder::setAddress);
Optional.ofNullable(getDataStreamAddress()).ifPresent(builder::setDataStreamAddress);
+
Optional.ofNullable(getClientAddress()).ifPresent(builder::setClientAddress);
+ Optional.ofNullable(getAdminAddress()).ifPresent(builder::setAdminAddress);
Review comment:
Is there a need in build() to check whether these address are different
or it is ok to reuse the same address for these fields (I am not sure, just
asking)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
