adoroszlai commented on a change in pull request #401:
URL: https://github.com/apache/incubator-ratis/pull/401#discussion_r562480949
##########
File path: ratis-examples/src/main/bin/common.sh
##########
@@ -38,7 +38,7 @@ fi
echo "Found ${ARTIFACT}"
-QUORUM_OPTS="--peers n0:localhost:6000,n1:localhost:6001,n2:localhost:6002"
+QUORUM_OPTS="--peers
n0:localhost:6000:6010:6020:6030,n1:localhost:6001:6011:6021:6031,n2:localhost:6002:6012:6022:6032"
Review comment:
> The port setting should be optional, i.e. when there is only a single
port, it will be used for both client and admin.
It is optional. I changed it here to prove it works, but I'm OK reverting
it.
##########
File path: ratis-grpc/src/main/java/org/apache/ratis/grpc/GrpcFactory.java
##########
@@ -61,17 +64,41 @@ public static Parameters newRaftParameters(GrpcTlsConfig
conf) {
}
public GrpcFactory(Parameters parameters) {
- this(GrpcConfigKeys.TLS.conf(parameters));
+ this(
+ GrpcConfigKeys.Admin.tlsConf(parameters),
+ GrpcConfigKeys.Client.tlsConf(parameters),
+ GrpcConfigKeys.Server.tlsConf(parameters),
+ GrpcConfigKeys.TLS.conf(parameters));
}
public GrpcFactory(GrpcTlsConfig tlsConfig) {
+ this(null, null, null, tlsConfig);
+ }
+
+ private GrpcFactory(GrpcTlsConfig adminTlsConfig, GrpcTlsConfig
clientTlsConfig,
+ GrpcTlsConfig serverTlsConfig, GrpcTlsConfig tlsConfig) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
