adoroszlai commented on a change in pull request #401:
URL: https://github.com/apache/incubator-ratis/pull/401#discussion_r562482594
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcService.java
##########
@@ -82,8 +103,10 @@ public static Builder newBuilder() {
return new Builder();
}
- private final Server server;
+ private final Set<Server> servers = new LinkedHashSet<>(3);
Review comment:
My intention was to rely on reference equality here. But since items
are added to `servers` only if they are different (using the
`separateAdminServer` etc. flags), we don't really need a `Set`, so I changed
it to a `List`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
