Hi Xinyu, Sounds good, let's wait for RATIS-2329.
Tsz-Wo On Sat, Oct 4, 2025 at 8:59 PM Xinyu Tan <[email protected]> wrote: > Hi, Tsz Wo > > Let’s patiently wait for the merge of Ratis 2329 to ensure that the > Celeborn community can fix this replication stuck issue in the 3.2.1 > release. I think it can be completed and merged after the National holiday. > > Best > ------------- > Xinyu Tan > > On 2025/10/02 16:46:57 Tsz Wo Sze wrote: > > Hi Xinyu, > > > > I am fine either way. > > > > RATIS-2329 is missing super.channelInactive(ctx). If the current code is > > working, it is okay to merge it without adding > super.channelInactive(ctx). > > We may add it later if there is a problem. > > > > Tsz-Wo > > > > > > On Thu, Oct 2, 2025 at 6:15 AM Xinyu Tan <[email protected]> wrote: > > > > > Hi > > > > > > As ratis 2332, 2339 and 2337 has been merged, maybe we can start > > > releasing rc2? Or I can wait for the mergement of 2329, it's good to > me now~ > > > > > > Best > > > --------------- > > > Xinyu Tan > > > > > > On 2025/09/28 14:50:29 Xinyu Tan wrote: > > > > Hi, all > > > > > > > > Thank you all for the reminders. It appears that I did not clean up > the > > > previous tag properly, which caused an issue with the tag uploaded for > rc1. > > > I will pay attention to this when preparing rc2. > > > > > > > > As for whether the tag should be pushed only before sending out the > > > email, I do need the CI status for the corresponding tag each time I > send a > > > voting email. Once an rc needs to be redone, the earlier steps with > svn and > > > mvn must be repeated, which is unavoidable. I believe it is reasonable > to > > > push the release and tag together, verify that CI passes, and then > send the > > > email; if CI fails, we should delete the corresponding branch and tag > and > > > redo the process. I have opened a new PR [1] for this. > > > > > > > > In addition, I plan to prioritize merging 2239 and 2238, then cut rc2 > > > from the latest commit on master. If 2329 can be updated in time, it > can be > > > included as well. I expect to release rc2 before the National Day > holiday. > > > Let us review and merge these PRs these days! > > > > > > > > [1] https://github.com/apache/ratis/pull/1293 > > > > > > > > Best > > > > ---------------- > > > > Xinyu Tan > > > > > > > > > > > > On 2025/09/28 07:46:51 Attila Doroszlai wrote: > > > > > Hi Xinyu, > > > > > > > > > > Thanks for working on the release. > > > > > > > > > > Please push your local RC branch to the apache/ratis repo. > According > > > > > to the naming convention it should be "release-3.2.1" > > > > > (https://github.com/apache/ratis/branches/all?query=release). > This > > > > > will fix the "commit does not belong to any branch on this > repository" > > > > > issue. > > > > > > > > > > The tag (ratis-3.2.1-rc1) should be pushed only before sending out > the > > > > > RC vote email, to avoid having to re-create it in case of any CI > > > > > problem (which could be seen in the branch's runs). > > > > > > > > > > Original: > > > > > > > > > > tag ratis-3.2.1-rc1 > > > > > Tagger: OneSizeFitQuorum <[email protected]> > > > > > Date: Sun Sep 7 13:15:16 2025 +0800 > > > > > ... > > > > > commit 93632a93a6013dd9946e5297cfba61c39e1f1239 (tag: > ratis-3.2.1-rc1) > > > > > > > > > > Current: > > > > > > > > > > tag ratis-3.2.1-rc1 > > > > > Tagger: OneSizeFitQuorum <[email protected]> > > > > > Date: Wed Sep 24 00:04:45 2025 +0800 > > > > > ... > > > > > commit 9156998c9be938bc5161368bf83671f72acd47e9 (tag: > ratis-3.2.1-rc1) > > > > > > > > > > -Attila > > > > > > > > > > > > > > >
