joshelser commented on a change in pull request #19: 
RATIS-549,RATIS-550,RATIS-552,RATIS-553 Metric Framework for Ratis
URL: https://github.com/apache/incubator-ratis/pull/19#discussion_r283914753
 
 

 ##########
 File path: 
ratis-logservice/src/test/java/org/apache/ratis/logservice/LogServiceReadWriteBase.java
 ##########
 @@ -64,6 +69,46 @@
   static final int NUM_PEERS = 3;
   CLUSTER cluster;
 
+  class MetricLogStream extends LogStreamImpl{
 
 Review comment:
   Did you intend to put this in `src/test/java`? Would have expected this to 
be in `src/main/java` and used implicitly in the client code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to