joshelser commented on a change in pull request #19:
RATIS-549,RATIS-550,RATIS-552,RATIS-553 Metric Framework for Ratis
URL: https://github.com/apache/incubator-ratis/pull/19#discussion_r285209334
##########
File path:
ratis-logservice/src/main/java/org/apache/ratis/logservice/server/LogStateMachine.java
##########
@@ -230,9 +279,18 @@ public StateMachineStorage getStateMachineStorage() {
}
+ private CompletableFuture<Message> recordTime(Timer timer, Task task) {
Review comment:
Maybe lift this up to some common, abstract StateMachine implementation so
we can use it for both the MetadataStateMachine and the LogStateMachine? Or a
utility class is fine too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
