joshelser commented on a change in pull request #25: RATIS-588 LogStream
StateMachine export
URL: https://github.com/apache/incubator-ratis/pull/25#discussion_r299653108
##########
File path:
ratis-logservice/src/main/java/org/apache/ratis/logservice/client/LogServiceClient.java
##########
@@ -172,8 +230,12 @@ void archiveLog(LogName name) throws IOException {
* @param name The name of the log to close
*/
// TODO this name sucks, confusion WRT the Java Closeable interface.
- void closeLog(LogName name) throws IOException {
- //TODO: write me
+ public void closeLog(LogName name) throws IOException {
+ RaftClientReply reply = getRaftClient(getLogInfo(name)).send(
Review comment:
Same comment here about getting a new `RaftClient`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
