joshelser commented on a change in pull request #25: RATIS-588 LogStream
StateMachine export
URL: https://github.com/apache/incubator-ratis/pull/25#discussion_r299661659
##########
File path:
ratis-logservice/src/test/java/org/apache/ratis/logservice/server/TestMetaServer.java
##########
@@ -123,6 +129,41 @@ public void testReadWritetoLog() throws IOException,
InterruptedException {
assert(res.array().length > 0);
}
+ @Test
+ public void testLogArchival() throws IOException, InterruptedException {
Review comment:
Can you add some more tests, please?
Should have an e2e UT how this would work for users. Could set a local
filesystem path (e.g. file:///..) and then use the LogServiceClient to trigger
the archive of the log. Then, validate that the file can read from the
archive'd log path.
Same goes for the export use-case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
