On 8/14/12 1:07 PM, "Chris Geer" <[email protected]> wrote:
> > >> On Aug. 7, 2012, 5:21 p.m., Raminder Singh wrote: >> > Patch works well . We dont have alert in rave and most of the >>validation are done by required attribute. HTML5 have >>required="required" for textarea also. Can we try using that? Thats >>better for mobile versions also. > >Question: I was researching the required field for some use in our >product and everything I've read says that support for it in Safari isn't >great and it only works on IE in version 10+. Since there are a lot of >people using Safari and IE < 10 how are they notified that a field is >required without another alert mechanism? I believe that Modernizr (script that we added) makes some of these features work in older browsers. > > > >- Chris > > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/6240/#review9971 >----------------------------------------------------------- > > >On Aug. 14, 2012, 5:02 p.m., Daniel Gornstein wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/6240/ >> ----------------------------------------------------------- >> >> (Updated Aug. 14, 2012, 5:02 p.m.) >> >> >> Review request for rave. >> >> >> Description >> ------- >> >> This patch does not allow empty comments to be posted on a widget in >>the store. If you try to post an empty comment an alert box pops up >>asking you to please enter text into the comment field. >> >> Also added a line which clears out the comment field after posting a >>comment. Before, the same text you just submitted was still populated in >>the comment box. >> >> >> Diffs >> ----- >> >> >>trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp >>1372847 >> >>trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js >>1372847 >> >> Diff: https://reviews.apache.org/r/6240/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Daniel Gornstein >> >> >
