-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6240/#review10427
-----------------------------------------------------------
i tried your changes and they are working well. only problem rightnow is to
validate empty spaces. That is a problem with other pages also. I tried to trim
space but i could not find how to show message in that case. Then it does not
go to if. Any ideas to show a message in else? we can always add an alert as
good old way :)
var comment = $.trim($("#newComment-"+widgetId).get(0).value);
- Raminder Singh
On Aug. 14, 2012, 5:02 p.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6240/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2012, 5:02 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> This patch does not allow empty comments to be posted on a widget in the
> store. If you try to post an empty comment an alert box pops up asking you to
> please enter text into the comment field.
>
> Also added a line which clears out the comment field after posting a comment.
> Before, the same text you just submitted was still populated in the comment
> box.
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
> 1372847
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js
> 1372847
>
> Diff: https://reviews.apache.org/r/6240/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>
