----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13883/#review25667 -----------------------------------------------------------
/branches/angular/rave-portal-resources/src/main/webapp/static/script/common/directives/RenderRegionWidget.js <https://reviews.apache.org/r/13883/#comment50169> You are using jquery without requiring it. Require angular and use angular.clone instead. This is preferred because 1) it is more readable and 2) I would like to reduce dependence on jquery to make it easier to remove in the future if we choose to. - Erin Noe-Payne On Aug. 28, 2013, 11:05 a.m., Daniel Gornstein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13883/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 11:05 a.m.) > > > Review request for rave. > > > Repository: rave > > > Description > ------- > > This directive renders a region widget into the markup with the directive. > This just renders the iframe and does not take care of any chrome. That will > be dealt with in a different controller > > > Diffs > ----- > > > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/directives/RenderRegionWidget.js > PRE-CREATION > > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/directives/index.js > 1518158 > > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PagesForRenderResource.js > 1518158 > > Diff: https://reviews.apache.org/r/13883/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Gornstein > >
